D17760: astyle: support the system astyle library

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Mar 11 14:50:08 GMT 2019


kossebau requested changes to this revision.
kossebau added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:3
>  
> +find_package(LibAStyle)
> +set_package_properties(LibAStyle PROPERTIES

Please check for version 3.*, given the current code relies on its API (and config keys?).

Not exactly sure which 3.*, 378a6e02cec55390c6dc903d98a035485ec1aa10 <https://phabricator.kde.org/R32:378a6e02cec55390c6dc903d98a035485ec1aa10> tells which kdevelop-side API changes had be done there.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17760

To: pino, mwolff, kossebau
Cc: arrowd, cullmann, mwolff, kossebau, kdevelop-devel, gennad, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190311/e94978ea/attachment.html>


More information about the KDevelop-devel mailing list