D22158: Navigation context uses theme color.

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Jun 30 09:26:24 BST 2019


apol added a comment.


  Patch looks good to me. Would you be able to offer screenshots using Breeze?

INLINE COMMENTS

> abstractnavigationcontext.h:77
> +
> +    Colorizer m_typeHighlight;
> +    Colorizer m_positionHighlight;

Given they're public API, I would remove the `m_` prefix.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22158

To: tristanp, #kdevelop
Cc: apol, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190630/0e28d56b/attachment.html>


More information about the KDevelop-devel mailing list