D22158: Navigation context uses theme color.

Tristan Porteries noreply at phabricator.kde.org
Sat Jun 29 21:46:08 BST 2019


tristanp created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
tristanp requested review of this revision.

REVISION SUMMARY
  Previously the navigation context (tool displaying information about
  code) was using fix white color theme. This was nice for people using
  light themes but for dark themes it looked like a lighhouse in the night.
  
  The solution proposed is to use colors from the common theme for
  background but also for text and code displayed in the tool panel.
  These colors are supposed to be contrasted enought and readable.
  
  Modifications are limited to AbstractNavigationContext and sub classes.
  AbstractNavigationContext hold a ColorizerTheme containing colors
  named as before (m_typeHighlight, m_positionHighlight, ...), this theme
  is retrieved from AbstractNavigationContext::theme() and every usage
  of xxxHiglight(string) is replaced by theme().m_xxxHiglight(string).
  
  Theme initialisation is proceeded into AbstractNavigationContext constructor
  with a KColorScheme.

REPOSITORY
  R32 KDevelop

BRANCH
  declaration_helper_color_theme

REVISION DETAIL
  https://phabricator.kde.org/D22158

AFFECTED FILES
  kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp
  kdevplatform/language/duchain/navigation/abstractincludenavigationcontext.cpp
  kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp
  kdevplatform/language/duchain/navigation/abstractnavigationcontext.h
  kdevplatform/language/duchain/navigation/abstractnavigationwidget.cpp
  kdevplatform/language/duchain/navigation/problemnavigationcontext.cpp
  kdevplatform/language/duchain/navigation/usesnavigationcontext.cpp
  plugins/clang/duchain/macronavigationcontext.cpp
  plugins/qmljs/duchain/navigation/declarationnavigationcontext.cpp

To: tristanp
Cc: kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190629/50dec041/attachment.html>


More information about the KDevelop-devel mailing list