D22158: Navigation context uses theme color.
noreply at phabricator.kde.org
Sat Jun 29 21:46:08 BST 2019
tristanp created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
tristanp requested review of this revision.
Previously the navigation context (tool displaying information about
code) was using fix white color theme. This was nice for people using
light themes but for dark themes it looked like a lighhouse in the night.
The solution proposed is to use colors from the common theme for
background but also for text and code displayed in the tool panel.
These colors are supposed to be contrasted enought and readable.
Modifications are limited to AbstractNavigationContext and sub classes.
AbstractNavigationContext hold a ColorizerTheme containing colors
named as before (m_typeHighlight, m_positionHighlight, ...), this theme
is retrieved from AbstractNavigationContext::theme() and every usage
of xxxHiglight(string) is replaced by theme().m_xxxHiglight(string).
Theme initialisation is proceeded into AbstractNavigationContext constructor
with a KColorScheme.
Cc: kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel