D22660: Fixed crash when filtering class list

[Marcin Dłubakowski]

mdlubakowski created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
mdlubakowski requested review of this revision.

REVISION SUMMARY
  Related: BUG 406931
  Issue: When you select an inner node (method or member) in Classes panel, then type something in search bar that filters that node out, Kdevelop crashes.
  It seems that when nodes get filtered, at some point currentIndex of QTreeView points to deleted node, which causes segfault in ClassModel::hasChildren.
  Manually invalidating currentIndex before filtering seems to have fixed the issue, I would appreciate if somebody else tested that too.

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22660

AFFECTED FILES
  plugins/classbrowser/classwidget.cpp

To: mdlubakowski
Cc: kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190722/a1d8a192/attachment.html>