D22424: TextDocument: remove actions from contextmenu on hide already

[René J.V. Bertin]

rjvbb added a comment.


  >   There is another condition here: `if (lastShownMenu)`. So if the QMenu object instance got deleted
  
  You mean I should do something like this?
  
    +        if (menu != lastShownMenu.data()) {
    +            if (lastShownMenuSet) {
    +                // don't warn about setting the cache for the 1st time
    +                qCWarning(SHELL) << "Added items to new contextmenu" << menu;
    +            }
    +            lastShownMenu = menu;
    +            lastShownMenuSet = true;
    +        }
  
  Same effect for now, no debug output.
  
  >   > Wouldn't it be great if something in my patch prevented the re-creation of the ctx menu instance? O:-)
  >   
  >   Fear "Something" not closer defined otherwise in software has a small chace of getting the "great" attribute ;)
  
  Which is why I said "it", not referring to my patch.
  I find that a perfectly analysed fix rarely qualifies for great either: with hindsight most things you understand always become trivial (and the things they fix, the opposite of great) O:-)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22424

To: kossebau, #kdevelop
Cc: anthonyfieroni, rjvbb, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190720/c8f657a6/attachment-0001.html>