D22158: Navigation context uses theme color.

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Interesting approach, might work out, thanks for doing this :)
  
  Not sure yet about all color mappings, that might need some more thinking, at least on a quick test across themes that resulted in quite some unreadable variants. Will play a bit during the upcoming WE.
  
  One thing which might be nice to have added (later) is an automatic update on color scheme changes, which would be at least useful for the Code Browser tool view to not look out of place on a change (especially important on testing color schemes ;) ).

INLINE COMMENTS

> declarationnavigationcontext.cpp:64
>          // and try to print it! The function most of the time has no name.
> -        modifyHtml() += typeHighlight(type->toString().toHtmlEscaped());
> +        modifyHtml() += theme().m_typeHighlight(type->toString().toHtmlEscaped());
>      } else {

m_typeHighlight -> typeHighlight

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22158

To: tristanp, #kdevelop
Cc: kossebau, apol, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190705/06195890/attachment.html>