D22197: Add working directory to clang parser.
Ben Wagner
noreply at phabricator.kde.org
Mon Jul 1 20:05:36 BST 2019
bungeman created this revision.
bungeman added a reviewer: KDevelop.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
bungeman requested review of this revision.
REVISION SUMMARY
This sets the working directory of the clang parser similarly to the way
the build directory is passed to the builder. This allows the parser to
correctly resolve any relative paths in the extra build arguments. This
means relative paths are resolved relative to the build directory (as
they would be resolved by a builder).
TEST PLAN
In the current test setup it doesn't seem the TestProject allows a TestBuildSystemManager, so it seems like quite a bit of work to create a test for this. (As a result I assume IBuildSystemManager integration isn't well tested in general right now.) If this needs a test, let me know if adding a TestBuildSystemManager is the right way to go.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D22197
AFFECTED FILES
plugins/clang/clangparsejob.cpp
plugins/clang/duchain/clangparsingenvironment.cpp
plugins/clang/duchain/clangparsingenvironment.h
plugins/clang/duchain/parsesession.cpp
To: bungeman, #kdevelop
Cc: kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190701/0faf3a52/attachment.html>
More information about the KDevelop-devel
mailing list