D22182: Remove anchorClicked lock which causes deadlock

[Michael Swan]

mswan created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
mswan requested review of this revision.

REVISION SUMMARY
  This change fixes a deadlock discussed in bug #358787. This lock was introduced to solve bug #386901.
  I looked through all of the paths to the failed assertion discussed in that latter ticket and it appears that all but
  the invocation in PotentialBuddyCollector::accept is verified to have the reader lock held prior to invocation. There
  were two paths which needed a lock added given my change, so this change set should not cause any regression on
  bug #386901.

REPOSITORY
  R32 KDevelop

BRANCH
  fix-anchorClicked

REVISION DETAIL
  https://phabricator.kde.org/D22182

AFFECTED FILES
  kdevplatform/language/duchain/navigation/abstractnavigationwidget.cpp

To: mswan
Cc: kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190701/8a2a5b59/attachment.html>