D18567: Make testActiveDocumentsGetBestPriority() clean up after itself

Thomas Schöps noreply at phabricator.kde.org
Sun Jan 27 19:15:57 GMT 2019


thomassc created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
thomassc requested review of this revision.

REVISION SUMMARY
  This patch makes testActiveDocumentsGetBestPriority() wait for the TestFiles it uses to be parsed, which prevents clang errors like "error: error reading '/tmp/testfile_SD1554.cpp'" that happen if these files get removed early. It also makes this test close the documents it opens, which prevents potential crashes in TestDUChain::cleanupTestCase() (and perhaps other issues).

TEST PLAN
  Run plugins/clang/tests/test_duchain-clang

REPOSITORY
  R32 KDevelop

BRANCH
  clang_duchain_testActiveDocumentsGetBestPriority_fix_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18567

AFFECTED FILES
  plugins/clang/tests/test_duchain.cpp

To: thomassc
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190127/e0ac56b1/attachment.html>


More information about the KDevelop-devel mailing list