D5447: Only add auto-detected compilers to model if they actually exist

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  the path of the compiler is now always the path of the compiler in the local host, which breaks when you have a runtime with a different setup. I think the changes that use `QStandardPaths` in `registerDefaultCompilers` should be undone and we should instead check the validity better elsewhere.
  
  So, the question really is: Why was the code inloc 213 in `compilerprovider.cpp` not working for you? If `gcc` wasn't installed, we should get:
  
  - `compiler->path() == "gcc"`, i.e. not absolute
  - `QStandardpaths::findExecutable("gcc", path)` should always return false for all the entries in your `PATH`
  - we should thus never set the gcc compiler
  
  please debug why the above didn't work for you

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190124/dd871141/attachment.html>