D18414: Prevent the Extra Arguments ComboBox to Stretch Too Much

David Narváez noreply at phabricator.kde.org
Sun Jan 20 19:22:15 GMT 2019


narvaez created this revision.
narvaez added a reviewer: KDevelop.
narvaez added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
narvaez requested review of this revision.

REVISION SUMMARY
  This basically ports d56117d68f2 <https://phabricator.kde.org/R32:d56117d68f29fff86103758078d6cc0f7bae6dab> to the build dir chooser.

TEST PLAN
  Create a new project from template (pick any template, any valid name) and add some ridiculously long cmake extra arguments (say, -DTEST=<really long string>), then create a new project again and look at the size of the Extra Arguments combo box.

REPOSITORY
  R32 KDevelop

BRANCH
  cmake-extra-arguments

REVISION DETAIL
  https://phabricator.kde.org/D18414

AFFECTED FILES
  plugins/cmake/cmakebuilddirchooser.cpp

To: narvaez, #kdevelop
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190120/759adefc/attachment.html>


More information about the KDevelop-devel mailing list