D18325: Debugger plugin fixes

[Igor Kushnir]

igorkushnir created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
igorkushnir requested review of this revision.

REVISION SUMMARY
  Rename Qt logging category: common -> debuggercommon
  
  The old name was too generic and undescriptive. This resulted in
  the following confusing lines in KDevelop output:
  
    kdevelop.plugins.common: Change session  QObject(0x0)
    kdevelop.plugins.common: Will reparse arch
  
  MIDebugger: print a specific process error message
  
  Information in the messageboxes is general and sometimes insufficient
  to understand why the process could not be started. In such cases
  a warning-level error message can be useful. For example:
  
    Debugger ERRORED QProcess::FailedToStart "execvp: Exec format error"
    Debugger ERRORED QProcess::WriteError "Error writing to process"
  
  GdbDebugger: pass correct string in userCommandOutput()
  
  When Shell script was not empty, both the shell path and the debugger
  executable were duplicated in the string sent to userCommandOutput()
  because they are prepended to arguments in if(!shell.isEmpty()) branch.

TEST PLAN
  Run test_gdb, test_gdbprinters, test_lldb and test_lldbformatters.
  The number of failed and skipped tests did not change with these fixes.

REPOSITORY
  R32 KDevelop

BRANCH
  debugger-plugin-fixes

REVISION DETAIL
  https://phabricator.kde.org/D18325

AFFECTED FILES
  plugins/debuggercommon/CMakeLists.txt
  plugins/debuggercommon/midebugger.cpp
  plugins/gdb/gdb.cpp

To: igorkushnir
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190117/ee713fa0/attachment.html>