D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J.V. Bertin]

rjvbb added a comment.


  Milian Wolff wrote on 20190112::12:35:11 re: "D16882 <https://phabricator.kde.org/D16882>: [KDevelop/Shell] prevent duplicate added contextmenu actions"
  
  >> mwolff wrote in textdocument.cpp:691
  >>  can't you just add a slot here that removes the actions we added once the menu is closed? that would fix this issue with way less code
  > 
  > and with slot I mean an local lambda that takes a copy of the actions list
  
  I agree that would be more elegant, and there was code (yours, IIRC) which aimed to do this. The problem is that for some reason the aboutToClose signal is not reliable.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau, mwolff
Cc: mwolff, egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190112/615a7a95/attachment-0001.html>