D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

Milian Wolff noreply at phabricator.kde.org
Sat Jan 12 12:34:30 GMT 2019


mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> textdocument.cpp:691
> -        menu->addAction(action);
> -    }
> -}

can't you just add a slot here that removes the actions we added once the menu is closed? that would fix this issue with way less code

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau, mwolff
Cc: mwolff, egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190112/d75aad7c/attachment.html>


More information about the KDevelop-devel mailing list