D17255: KDevelop: support for installing into a non-standard parallel prefix

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cmakeutils.h:120
> +     * @returns the current install dir for the given project or an empty string if none has been defined
> +     * (in that case, whatever default CMake sets for the platform will be used.)
>       */

make sure to add this information to the dialog that asks for the install dir and ensure that it shows something like 'default' in it's click message and something more elaborate in the tooltip

> kfunk wrote in manpageplugin.cpp:98
> I wonder if we just want to remove that complete if-branch altogether... Not entirely sure what it is trying to work-around.

commit 194b97e1d14681d2470193beb746819a38e3ecee
  Author: David nolden <david.nolden.kde at art-master.de>
  Date:   Thu Feb 3 11:39:24 2011 +0100
  
      - Don't show manpage documentation for declarations that are not in /usr/
      - Don't show manpage documentation for declarations that are in the current project
      It was very annoying to see manpage documentation just because the function-name accidentally matches something that has a manpage (for example "test")

it sounds like a major cause for annoyance, but I agree that the current workaround might be a bit too much?

but then again, why should we un-ignore stuff in the KDEVELOP_INSTALL_PREFIX?!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17255

To: rjvbb, #kdevelop, kfunk, mwolff
Cc: mwolff, arrowd, brauch, apol, flherne, kfunk, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190112/6dcdef7e/attachment-0001.html>