D17909: Clang plugin: Handle CUDA files better

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jan 2 17:51:21 GMT 2019


apol added a comment.


  The patch looks good overall +1

INLINE COMMENTS

> parsesession.cpp:108
> +        auto result = parserSettings.toClangAPI();
> +        result.append(QByteArrayLiteral("-xcuda"));
> +        return result;

Doesn't this need a space in the beginning?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17909

To: thomassc, #kdevelop
Cc: apol, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190102/b59fac29/attachment-0001.html>


More information about the KDevelop-devel mailing list