D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  could you fixup the two minor nits please? then you can push directly

INLINE COMMENTS

> iprojectcontroller.h:156
> +     */
> +    virtual void reparseProject( IProject* project, bool ForceUpdate = false, bool forceAll = false ) = 0;
>  

while at it, please lowercase the `forceUpate`

> projectcontroller.cpp:1183
> +
> +        QAction *action = new QAction(this);
> +        connect(action, &QAction::triggered, this, [&] {

style:

  auto* action = new QAction(tr("Reparse the Entire Project"), this);
  ...

And is the capitalization HIG conform? I always forget it. Looks somewhat funny that the `the` is lower case but `Entire` isn't. But could be that this is correct - if this was a deliberate decision by you I'm fine with it.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D11934

To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, gennad, glebaccon, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190211/e0205a23/attachment.html>