D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted.
noreply at phabricator.kde.org
Sun Feb 10 19:04:36 GMT 2019
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
I'm afraid to say that this is just a workaround, not a proper fix... I ran into this issue recently too - the real problem - imo - is that we synchronously execute the stat jobs in KDevelop::ProjectPrivate::initProjectFiles... if you look at the ASAN report you'll see that TestCore::shutdown isn't referenced there at all!
it's not really an option to add random waits to the tests in the hope to workaround the issue everywhere. Rather, we should try to remove such nested eventloops somehow, even if that means refactoring the codebase...
To: arrowd, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, gennad, glebaccon, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel