D18857: optimize CMakeBuildDirChooser::buildDirSettings()

Rolf Eike Beer noreply at phabricator.kde.org
Fri Feb 8 16:58:02 GMT 2019


dakon created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
dakon requested review of this revision.

REVISION SUMMARY
  -if we have a match for a key, no other key can match
  -match the start of a new line as QByteArray instead of QString, most lines will
   not match and all keys are plain ASCII, this saves a lot of needless
   conversions and memory allocations
  -modify the original line instead of doing a copy, the original one will not
   be used again anyway.

TEST PLAN
  Open and build a CMake-based project.

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18857

AFFECTED FILES
  plugins/cmake/cmakebuilddirchooser.cpp

To: dakon
Cc: kdevelop-devel, glebaccon, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190208/f92567c4/attachment.html>


More information about the KDevelop-devel mailing list