D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted.
noreply at phabricator.kde.org
Mon Apr 15 09:13:28 BST 2019
mwolff added a comment.
In D18758#450081 <https://phabricator.kde.org/D18758#450081>, @apol wrote:
> In D18758#449319 <https://phabricator.kde.org/D18758#449319>, @mwolff wrote:
> > Oh, really? Hmm! I wouldn't be opposed to enable compilation with exceptions myself, what do the others say? We don't need to use them excessively, but for error handling in async promise chains, that would be quite useful I think?
> That would mean adding a bunch of `noexcept` all over the place or risk quite some performance penalty. I'd prefer keeping it localised.
We only get bigger binaries - and the impact is left to be seen. That said, I also would prefer to keep it localized. We could probably get away with only enabling exceptions wherever QtPromise is being used, so make it an interface property of that target in cmake?
To: arrowd, #kdevelop, mwolff
Cc: apol, kfunk, brauch, mwolff, kdevelop-devel, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel