D5447: Only add auto-detected compilers to model if they actually exist

[Gleb Popov]

arrowd added inline comments.

INLINE COMMENTS

> mwolff wrote in androidruntime.cpp:98
> @arrowd the PATH list here should still be going through `pathInHost`, otherwise it will point to the wrong directories. so it would be something like:
> 
>   QStringList rtPaths = paths;
>   if (rtPaths.isEmpty()) {
>       // transform "PATH" env var values into rtPaths
>   }
>   // lookup using rtPaths
> 
> @apol how would you implement this?

`getenv` there is `IRuntime::getenv()`. If I understand it right, it returns paths inside the RT, just what we need.

> mwolff wrote in compilerfactories.cpp:51
> shouldn't be required, we find the executable internally by name after all

Hmm. But the second arg of `createCompiler` is called `path`, and whole this patch is about passing a full path there.

Probably, in presence of such thing as runtimes, we need to revise Compiler's API and do something about `path()` method?

> mwolff wrote in dockerruntime.cpp:256
> all I said in the android runtime applies here too I believe
> 
> also, the code is identical, so share it trough some "runtime helper header"

> also, the code is identical, so share it trough some "runtime helper header"

Where to put it?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arrowd, mwolff, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190401/b0cb78b3/attachment-0001.html>