D15743: Fix removal of external scripts

[Amish Naidu]

amhndu marked an inline comment as done.
amhndu added inline comments.

INLINE COMMENTS

> flherne wrote in externalscriptplugin.cpp:392
> We don't need this at all, it's effectively a reimplementation of KConfigGroup::groupList() <https://api.kde.org/frameworks/kconfig/html/classKConfigGroup.html#a1f776ccf3815c32e84c0816403e249b6>.
> 
> In principle yours is more efficient for this purpose (doesn't needlessly convert the set to a list), but the number of external-scripts will never be large enough for that to matter.

Thanks, wasn't aware of that function.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15743

To: amhndu, #kdevelop, flherne
Cc: flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180928/ba34f69a/attachment-0001.html>