D15764: [Custom-DefinesAndIncludes]: Objective-C++ support

[Aaron Puchert]

aaronpuchert added a comment.


  Given that `languageOption` also has `Q_UNREACHABLE()`, and both are always called together, any crash that could happen would have already happened before. The function is called from `CompilerProvider::{defines,includes}` and both catch the `Other` case before calling into the `ICompiler` implementation. Maybe we should document the constraint (`type != Utils::Other`) in the `ICompiler` interface, but we should do it in a separate commit.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15764

To: rjvbb, #kdevelop, aaronpuchert
Cc: aaronpuchert, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180927/ff2ef52d/attachment.html>