D15764: [Custom-DefinesAndIncludes]: Objective-C++ support

René J.V. Bertin noreply at phabricator.kde.org
Wed Sep 26 18:22:40 BST 2018

rjvbb marked 2 inline comments as done.
rjvbb added inline comments.


> aaronpuchert wrote in gcclikecompiler.cpp:69
> Now that we pass in the language type, maybe we should handle all cases. So for `C` and `ObjC` we don't want to return an empty string, but (say) `-std=c99`. Maybe we can make this match the default arguments in plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp.

Done. You know I dislike multiple exit points but for you I avoided a temp. var and as many kinda superfluous `break`s ;)

  R32 KDevelop


To: rjvbb, #kdevelop
Cc: aaronpuchert, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180926/a0f19ca1/attachment.html>

More information about the KDevelop-devel mailing list