D15743: Fix removal of external scripts

[Amish Naidu]

amhndu created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
amhndu requested review of this revision.

REVISION SUMMARY
  Deleting a script which is in the middle of the config would invalidate indices
  of the scripts that come after it in the config, this would mean deleting
  anything later deletes the wrong script.
  
  BUG: 385298

TEST PLAN
  - Before applying the patch:
    - Delete "Google Selection"
    - Restart
    - Delete "Quick Compile"
    - Restart and check list of external scripts
  
  - Apply the patch and repeat.

REPOSITORY
  R32 KDevelop

BRANCH
  script-remove-bug

REVISION DETAIL
  https://phabricator.kde.org/D15743

AFFECTED FILES
  plugins/externalscript/externalscriptplugin.cpp

To: amhndu
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180925/eece04ce/attachment.html>