D15625: Sublime: Fix crash caused when all tool view items are small

[Amish Naidu]

amhndu updated this revision to Diff 42268.
amhndu added a comment.


  Re-implemented Ideal Layout's minimumSize which accumulates the newly added
  minimumSize in Ideal Button.
  The previous buggy implementation of minimumSize in the Ideal Layout called the doVerticalLayout
  with a zero rect, although the height is passed from a property, but it is never set to anything
  non-zero, which is what caused problems with some QtCurve configs.
  
  I've also checked and it seems that setHeight and height are no longer used anymore in Ideal Layout
  or outside, should I go ahead and remove it avoid confusion from a dead property ?

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15625?vs=42102&id=42268

BRANCH
  segfault-fix

REVISION DETAIL
  https://phabricator.kde.org/D15625

AFFECTED FILES
  kdevplatform/sublime/ideallayout.cpp
  kdevplatform/sublime/idealtoolbutton.cpp
  kdevplatform/sublime/idealtoolbutton.h

To: amhndu, #kdevelop, kossebau, rjvbb
Cc: kossebau, rjvbb, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180924/e5f3d6cd/attachment-0001.html>