D15625: Sublime: Fix crash caused when all tool view items are small

Amish Naidu noreply at phabricator.kde.org
Mon Sep 24 14:25:46 BST 2018


amhndu added a comment.


  > are you sure the comparison should be itemWidth <= maximumWidth and not a simple < instead?
  
  The reasoning was that Items that have `maximumWidth` size needn't be shrinked, as that's the maximum size that's allowable.
  
  > It would be more interesting to know why items (and rect) could have 0 width or height
  
  `rect` shouldn't be, the (buggy, which should probably be fixed) `IdealButtonBarLayout::minimumSize` returns something non-zero.
  
  Can you share your QtCurve config ?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15625

To: amhndu, #kdevelop, kossebau, rjvbb
Cc: kossebau, rjvbb, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180924/a30b66ec/attachment.html>


More information about the KDevelop-devel mailing list