D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks

[Aaron Puchert]

aaronpuchert added a comment.


  There are two suspicious fallthroughs, maybe someone with a better understanding than me can comment on that.

INLINE COMMENTS

> ghproviderwidget.cpp:166
>          enabled = false;
> +        Q_FALLTHROUGH();    // intentional?
>      default:/* Looking for some organization's repo. */

Looks suspicious to me, is that intended?

> context.cpp:459
>              stack.top().commas++;
> +            Q_FALLTHROUGH();    // intentional?
>          default:

Looks also suspicious.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15694

To: aaronpuchert, #kdevelop
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180922/c1b2647f/attachment.html>