D7930: Kdevelop CMake plugin : use canonical paths to build.dir

[René J.V. Bertin]

rjvbb updated this revision to Diff 42097.
rjvbb added a comment.


  Refactored for the 5.3 branch + completed.
  
  An example where this is required:
  
    mkdir -p work/src/KDE/KF5
    cd work/src/KDE
    git clone kde:kdevelop kdevelop-git
    cd KF5
    ln -s kdevelop5-git ../kdevelop
    (cd kdevelop5-git ; git checkout 5.3)
    mkdir kdevelop5-git/build
    # import kdevelop5-git into KDevelop,
    # configure with kdevelop5-git/build as build dir
    # (outside of KDevelop:)
    (cd kdevelop5-git/build/plugins/astyle ; make -w kdevastyle_autogen)
  
  For me this will fail on an include of configpage.h because it is looked for via a relative path that tries to access ~/work/src/KDE/kdevelop but fails because it is executed in ~/work/src/KDE/KF5/kdevelop5-git/build instead of ~/work/src/KDE/kdevelop/build. These paths refer to the same location on disk but differ in the number of path segments, as mentioned above.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7930?vs=20244&id=42097

REVISION DETAIL
  https://phabricator.kde.org/D7930

AFFECTED FILES
  plugins/cmake/cmakecommitchangesjob.cpp
  plugins/cmake/cmakeimportjsonjob.cpp
  plugins/cmake/cmakemanager.cpp
  plugins/cmake/cmakemodelitems.cpp
  plugins/cmake/cmakeserverimportjob.cpp
  plugins/cmake/cmakeutils.cpp
  plugins/cmake/cmakeutils.h
  plugins/cmake/settings/cmakepreferences.cpp
  plugins/cmakebuilder/cmakebuilder.cpp
  plugins/cmakebuilder/cmakejob.cpp

To: rjvbb, #kdevelop, apol, mwolff
Cc: flherne, mwolff, apol, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180921/23fdafc7/attachment.html>