D15450: Make sublime tool bar buttons shrinkable and elide text

Amish Naidu noreply at phabricator.kde.org
Sat Sep 15 07:27:39 BST 2018


amhndu added inline comments.

INLINE COMMENTS

> kossebau wrote in idealtoolbutton.cpp:46
> What exactly was the intent with this code? Given the layout code in the IdealButtonBarLayout class does not take the size policy or minimum size into account in the current logic, this would not work.
> 
> So unless the button is going to be inserted elsewhere, this added code can be removed again, or?

You're right, IdealButtonBarLayout does not consider this, but I was initially testing with a BoxLayout, since that's what the bottom bar used, I'll remove it.

REPOSITORY
  R32 KDevelop

BRANCH
  buttonbar-shrink

REVISION DETAIL
  https://phabricator.kde.org/D15450

To: amhndu, #kdevelop, kossebau
Cc: kossebau, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180915/36789169/attachment.html>


More information about the KDevelop-devel mailing list