D15326: Fix segfaults in OutputWidget
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Fri Sep 14 17:24:17 BST 2018
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
Patch looks good to me also on semantic reading. This should remove the crashes we have seen, and make the code less unusual when it comes to QWidget object handling.
As I think the mentioned bug is related and have seen the same backtrace meanwhile again as well, please add a line
to the summary of this review request, so arc (if you use it) will pick up that string when amending the patch with the latest text from here, and the KDE server commit push hooks then do the automatic closing of that bug once they process that commit message (just telling in case you do not know yet) :)
To: antonanikin, #kdevelop, kossebau
Cc: kfunk, kossebau, vkorneev, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel