D15326: Fix segfaults in OutputWidget

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Quick first feedback, will take a closer look in the evening. Positive first impression so far :)

INLINE COMMENTS

> outputwidget.cpp:650
> +    auto view = qobject_cast<QAbstractItemView*>(currentWidget());
> +    if(!view) {
>          return;

Please no drive-by changes to lines not touched otherwise, especially non-whitespace changes. That make the "git blame" annotations confusing.

> outputwidget.cpp:665
>      }
> -    QRegExp regExp(filter, Qt::CaseInsensitive);
> -    proxyModel->setFilterRegExp(regExp);
> +    proxyModel->setFilterRegExp(QRegExp(filter, Qt::CaseInsensitive));
>      fvIt->filter = filter;

Unrelated change?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15326

To: antonanikin, #kdevelop
Cc: kfunk, kossebau, vkorneev, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180914/db7722ac/attachment.html>