D15432: [StandardOutputView] Remove dead & broken code for prev_error/next_error

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: KDevelop, kfunk.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Commit 9ec8eee23ecbbb0176996542d054758262500240 had removed the custom
  actions prev_error & next_error in favour of some global actions with
  global shortcut, which would dynamically decide which result tool view to
  apply the action (e.g. by shortcut) on. Two things were forgotten:
  
  a) the plugin still installed a ui.rc file for those actions
  
  b) The OutputWidget still tried to get the two actions by their id from
  the plugin, to insert it into its own UI. Later the commit
  fc8d34f0b00a9d0f4bbf480b06a34a9190b46d20 also added generic actions to
  the widget. As a result of the failing action fetching two warnings
  QWidget::insertAction: Attempt to insert null action
  were seen on the log.
  
  This commit fixes both by removing the no longer useful code.

TEST PLAN
  Output widget still works WRT item navigation, both from main menu and from
  toolview actions.

REPOSITORY
  R32 KDevelop

BRANCH
  cleamprevnexterraction

REVISION DETAIL
  https://phabricator.kde.org/D15432

AFFECTED FILES
  plugins/standardoutputview/CMakeLists.txt
  plugins/standardoutputview/kdevstandardoutputview.qrc
  plugins/standardoutputview/kdevstandardoutputview.rc
  plugins/standardoutputview/outputwidget.cpp
  plugins/standardoutputview/standardoutputview.cpp

To: kossebau, #kdevelop, kfunk
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180911/0b80633f/attachment.html>