D15432: [StandardOutputView] Remove dead & broken code for prev_error/next_error
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Sep 11 15:20:26 BST 2018
kossebau created this revision.
kossebau added reviewers: KDevelop, kfunk.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
kossebau requested review of this revision.
Commit 9ec8eee23ecbbb0176996542d054758262500240 had removed the custom
actions prev_error & next_error in favour of some global actions with
global shortcut, which would dynamically decide which result tool view to
apply the action (e.g. by shortcut) on. Two things were forgotten:
a) the plugin still installed a ui.rc file for those actions
b) The OutputWidget still tried to get the two actions by their id from
the plugin, to insert it into its own UI. Later the commit
fc8d34f0b00a9d0f4bbf480b06a34a9190b46d20 also added generic actions to
the widget. As a result of the failing action fetching two warnings
QWidget::insertAction: Attempt to insert null action
were seen on the log.
This commit fixes both by removing the no longer useful code.
Output widget still works WRT item navigation, both from main menu and from
To: kossebau, #kdevelop, kfunk
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel