D15326: Fix segfaults in OutputWidget
Vyacheslav Korneev
noreply at phabricator.kde.org
Sat Sep 8 17:08:13 BST 2018
vkorneev added a comment.
As an author of D14931 <https://phabricator.kde.org/D14931> I need to apologize for passing this bug and clear a thing about the 2nd case.
In the first version of the aforementioned patch (https://phabricator.kde.org/D14931?id=40016) I used raw pointers instead of QSharedPointer and was calling helper FilteredView::destroy() method in OutputWidget::removeOutput() in order not to store potentially big view and proxy model objects in memory when we don't need them anymore. This shouldn't cause double deletion because children object should remove itself from object hierarchy when being deleted (as far as I understand). Maybe you can use it too if you want.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D15326
To: antonanikin, #kdevelop
Cc: vkorneev, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180908/e2b4587e/attachment.html>
More information about the KDevelop-devel
mailing list