D15241: Fix double delete bug in OutputWidget

[Vyacheslav Korneev]

vkorneev created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
vkorneev requested review of this revision.

REVISION SUMMARY
  The bug was unfortunately introduced in D14931 <https://phabricator.kde.org/D14931> by me - two shared pointers
  were created from the same raw pointer. Eliminated it by using QSharedPointer
  as a return value from view creation helper lambda.

TEST PLAN
  The bug can be triggered only in IOutputView:OneView widget mode, which is (as
  far as I can see) currently neither used, nor properly tested. Planning to change
  this in following patches.

REPOSITORY
  R32 KDevelop

BRANCH
  fix_outputwidget_bug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15241

AFFECTED FILES
  plugins/standardoutputview/outputwidget.cpp

To: vkorneev
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180903/f08cf330/attachment.html>