D15198: Sublime: on View destruction delete widget instantly, instead deleteLater

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: KDevelop.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Having a defined destruction order allows to make more assumptions
  in other code referring to the widgets and avoids extra work to track
  the addditional lifetime of the widget objects (like e.g. needed with
  the KTextEditor::View widget objects, which require the
  KTextEditor::MainWindow to exists as long as there is a View object).
  
  With the Sublime::View and the QWidget objects both bound to the same
  thread which is the UI objects thread by current design, there is also
  no need to defer the deletion into the QWidget object thread.

TEST PLAN
  Have been running this for more than a month, no issues seen.

REPOSITORY
  R32 KDevelop

BRANCH
  deleteViewWidgetsInSync

REVISION DETAIL
  https://phabricator.kde.org/D15198

AFFECTED FILES
  kdevplatform/shell/ktexteditorpluginintegration.cpp
  kdevplatform/shell/ktexteditorpluginintegration.h
  kdevplatform/shell/mainwindow.cpp
  kdevplatform/shell/tests/test_ktexteditorpluginintegration.cpp
  kdevplatform/sublime/view.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180901/bfa692ae/attachment.html>