D16461: Fix syntax support for dynamic member access.

Heinz Wiesinger noreply at phabricator.kde.org
Sun Oct 28 19:04:24 GMT 2018


pprkut marked 3 inline comments as done.
pprkut added inline comments.

INLINE COMMENTS

> kfunk wrote in expressionvisitor.cpp:790
> And probably needs a check against `...->staticProperty->staticProperty`, too?

With the current grammer, if there's `staticProperty`, there's also a `staticProperty->staticProperty`, so conceptually we don't need to check for both right now. However, the grammar can change, so it's probably good to be safe.

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D16461

To: pprkut, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181028/ecfe0798/attachment.html>


More information about the KDevelop-devel mailing list