D16461: Fix syntax support for dynamic member access.

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> expressionvisitor.cpp:738
> +                useDeclaration(node->staticProperty->staticProperty->variable, context);
> +            } else if (node->staticProperty->staticProperty && node->staticProperty->staticProperty->expr) {
> +                // variable static properties (object::${$property})

Same here

> expressionvisitor.cpp:790
> +                    // Handle dynamic static properties first, as they don't need a class context
> +                    if (it->element->staticProperty && it->element->staticProperty->staticProperty->expr) {
> +                        // variable static properties ($object::${$property})

And probably needs a check against `...->staticProperty->staticProperty`, too?

> expressionvisitor.cpp:819
>  
> -                    if (it->element->staticProperty) {
> +                    if (it->element->staticProperty && it->element->staticProperty->staticProperty->variable) {
>                          // static properties ($object::$property)

Same here(?)

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D16461

To: pprkut, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181028/234d3cc5/attachment-0001.html>