D16461: Fix syntax support for dynamic member access.

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> expressionvisitor.cpp:714
> +        }
> +    } else if (node->staticProperty->staticProperty) {
> +        if (node->staticProperty->staticProperty->expr) {

You already dereference `node->staticProperty->staticProperty` before in line 700; so this if-stmt would be always true(?). Doesn't make sense to me.

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D16461

To: pprkut, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181028/f79ce18a/attachment-0001.html>