D16218: [KDevelop/Core]: safe signal-handler implementation (WIP)

[René J.V. Bertin]

rjvbb marked an inline comment as done.
rjvbb added a comment.


  In D16218#343340 <https://phabricator.kde.org/D16218#343340>, @arrowd wrote:
  
  >
  
  
  
  
  > I am able to compile KDevelop master with and without your patch on my FreeBSD system. Even without `CMakeLists.txt` change.
  > 
  > What FreeBSD version are you running?
  
  Oh, misunderstanding! I simply don't have a full KF5 build environment on FreeBSD yet. I'm running TrueOS in a VM on a system that isn't exactly powerful, so I'm waiting until "Project Trident" is released with a full KF5 desktop option.

INLINE COMMENTS

> arrowd wrote in CMakeLists.txt:162
> The correct way to handle this is `FindThreads` CMake module, I guess.

But that would probably be a separate change that addresses the issue everywhere, no?

REVISION DETAIL
  https://phabricator.kde.org/D16218

To: rjvbb, #kdevelop
Cc: arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181015/005863ad/attachment.html>