D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools.

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdevelop-msvc.bat:22
> +	SET script="%base%..\..\VC\Auxiliary\Build\vcvarsall.bat" x64
> +) else ( IF NOT DEFINED VS150COMNTOOLS (
> +		REM Choosing architecture

I think this can be simplified quite a bit: I would move this whole block before line 3 (but do not call `vcvarsall.bat` yet, so we can reuse most of the logic from line 20ff.

I'll try to work on it later the day, probably easier if I just show the patch I have in mind.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15976

To: Petross404, #kdevelop, kfunk
Cc: kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181009/102b4391/attachment.html>