D15955: clang: Also detect Clang builtin dirs at runtime

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Confirmed to work on openSUSE TW:
  
    kdevelop.plugins.clang: Full Clang version: "clang version 6.0.1 (tags/RELEASE_601/final 335528)"
    kdevelop.plugins.clang: Detected Clang version: "6.0.1"
    kdevelop.plugins.clang: Using builtin dir: /usr/lib64/clang/6.0.1/include
    kdevelop.plugins.clang: Using Clang builtin include path: "/usr/lib64/clang/6.0.1/include"
  
  or when being nasty setting `KDEV_CLANG_BUILTIN_DIR=/does/not/exist`:
  
    kdevelop.plugins.clang: Full Clang version: "clang version 6.0.1 (tags/RELEASE_601/final 335528)"
    kdevelop.plugins.clang: Detected Clang version: "6.0.1"
    kdevelop.plugins.clang: Using dir from $KDEV_CLANG_BUILTIN_DIR: "/does/not/exist"
    kdevelop.plugins.clang: Using Clang builtin include path: "/does/not/exist"
  
  which results in unloading the clang plugin, as expected.

INLINE COMMENTS

> clangsupport.cpp:184
>          const auto builtinDir = ClangHelpers::clangBuiltinIncludePath();
> +        clangDebug() << "Using Clang builtin include path:" << builtinDir;
> +

This debug statement duplicates a bit those of ClangHelpers::clangBuiltinIncludePath(), could perhaps be removed again?

REPOSITORY
  R32 KDevelop

BRANCH
  5.3

REVISION DETAIL
  https://phabricator.kde.org/D15955

To: kfunk, kossebau, aaronpuchert, brauch
Cc: brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181005/e853ac4a/attachment.html>