D15606: Fix calling qdbus by using qt5-current name qdbus-qt5

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdevplatform_shell_environment.sh:74
> +# special handling for qdbus variants
> +_qdbus=qdbus
> +if ! [ "$(which $_qdbus 2> /dev/null)" ]; then

Maybe rename to `QDBUS_EXE`?

> kdevplatform_shell_environment.sh:74
> +# special handling for qdbus variants
> +_qdbus=qdbus
> +if ! [ "$(which $_qdbus 2> /dev/null)" ]; then

Shouldn't this prefer `qdbus-qt5` over `qdbus`, too?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15606

To: kossebau, #kdevelop, lbeltrame, fvogt, jriddell, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181004/d435cf58/attachment-0001.html>