D15895: Use CLANG_INCLUDE_DIRS for clang include dir

Bernd Buschinski noreply at phabricator.kde.org
Thu Oct 4 14:26:04 BST 2018


buschinski added inline comments.

INLINE COMMENTS

> kfunk wrote in FindClang.cmake:92
> IIUC then `CLANG_INCLUDE_DIRS` shouldn't be touched. `CLANG_INCLUDE_DIRS` is for finding the correct include dirs for building KDevClangSupport against libclang -- we don't need to have things like compiler builtin includes in there.
> 
> Rather, leave `CLANG_INCLUDE_DIRS` as it is and do `find_path(CLANG_BUILTIN_DIR ...)`, in other words: create another variable.
> 
> @buschinski Just to double-check: /usr/lib64/llvm/7/include has a `clang` subfolder on Gentoo, right?

Yes, there is a /usr/lib64/llvm/7/include/clang, but it does not contain cpuid.h or such headers.

And just to be clear, the original version looked for
"/usr/lib64/llvm/7/lib64/clang/7.0.0/include", which does not exist.

$ llvm-config --libdir
/usr/lib64/llvm/7/lib64
the double "lib64" sounds wrong, but it is correct, exists and does also contains lots of libclang*.

I will change it to CLANG_BUILTIN_DIR and revert the CLANG_INCLUDE_DIRS changes.

> kossebau wrote in FindClang.cmake:95
> I would like some comment why "cpuid.h" and some cross-linking between ClangSupport constructor and this.
> Unless cpuid.h is a header well known for such compiler/system includes testing, and I yet have to learn much more :)

"cpuid.h" is common (as far as I know) for compiler (gcc/clang), but not very clang specific. I will add a comment regarding ClangSupport constructor

> kfunk wrote in FindClang.cmake:104
> Typo: "Unabled"

rephrased to match other error messages to:
"Could not find Clang builtin directory"

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15895

To: buschinski, #kdevelop, kfunk
Cc: mwolff, aaronpuchert, brauch, kossebau, kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181004/602f2c74/attachment.html>


More information about the KDevelop-devel mailing list