D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Oct 2 23:04:59 BST 2018


kossebau added inline comments.

INLINE COMMENTS

> kfunk wrote in context.cpp:459
> Since this hunk is actually changing behavior, I'd commit it in a separate patch and also explain properly in the commit msg.
> 
> All other hunks are mainly cosmetic iiuc and can be committed in bulk.

@aaronpurchert This fix would be also candidate for 5.3 branch, right? If so, please cherry-pick -x it there, or tell me, I would do it then.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15694

To: aaronpuchert, #kdevelop, kossebau, kfunk
Cc: mwolff, apol, kfunk, rjvbb, brauch, mssola, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181002/35a86293/attachment.html>


More information about the KDevelop-devel mailing list