D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks

Kevin Funk noreply at phabricator.kde.org
Tue Oct 2 20:45:33 BST 2018


kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> context.cpp:459
>              stack.top().commas++;
> +            break;
>          default:

Since this hunk is actually changing behavior, I'd commit it in a separate patch and also explain properly in the commit msg.

All other hunks are mainly cosmetic iiuc and can be committed in bulk.

REPOSITORY
  R32 KDevelop

BRANCH
  cleanup-switch-statements

REVISION DETAIL
  https://phabricator.kde.org/D15694

To: aaronpuchert, #kdevelop, kossebau, kfunk
Cc: mwolff, apol, kfunk, rjvbb, brauch, mssola, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181002/3016dc47/attachment.html>


More information about the KDevelop-devel mailing list