D17168: Removes a crash related to include method

Samu Voutilainen noreply at phabricator.kde.org
Mon Nov 26 13:10:41 GMT 2018


Smar added inline comments.

INLINE COMMENTS

> apol wrote in usebuilder.cpp:90
> This doesn't look like a to do item. The context should already be created anyway.

Okay, good to know. I wasn’t sure so I added a todo to remind myself that I should check it later. Related, should I also remove the latter todo?

> apol wrote in usebuilder.cpp:95
> assert after if doesn't make any sense.

Yes, sorry for sloppy work.

REPOSITORY
  R58 KDevelop Ruby

REVISION DETAIL
  https://phabricator.kde.org/D17168

To: Smar, #kdevelop
Cc: apol, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181126/8cfb52a7/attachment-0001.html>


More information about the KDevelop-devel mailing list