D16942: CMakeCacheModel: avoid string memory duplication

[Rolf Eike Beer]

dakon created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
dakon requested review of this revision.

REVISION SUMMARY
  QString::mid() will create a new string, but this code path will never use the
  old variable again. So simply modify the original copy instead.
  
  CMakeCacheModel: remove impossible case
  
  Exactly the same case has been checked 2 if's before.

REPOSITORY
  R32 KDevelop

BRANCH
  cmcachemgr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16942

AFFECTED FILES
  plugins/cmake/settings/cmakecachemodel.cpp

To: dakon
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181117/4c4eaf57/attachment-0001.html>