D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Nov 15 00:29:12 GMT 2018


kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.


  Oh, I missed the latter "For an as-yet unknown reason populateContextMenu() will be called with every view in which the contextmenu has been opened when the CTags plugin is loaded. A bug in KTextEditor maybe?"
  
  Please, let's find the root causes and fix things at the base instead of adding such (even uncommented=unexplained=surprising) work-arounds for symptoms. Saves future code readers/maintainers from wanting to toast the original developers of such confusing bug/misbehaviour masking code.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181115/9d053d4d/attachment.html>


More information about the KDevelop-devel mailing list