D12743: Unit tests fixes

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  ouch, thanks a lot for the investigation. This is similar to the QStringBuilder crashes one can get... Can you simplify the line based on my suggestion? then it's a clear +2 from me, please also include the analysis and valgrind output in your commit message.

INLINE COMMENTS

> test_pluginenabling.cpp:138
>      // logic in kdevelop different from  KPluginMetaData::isEnabledByDefault(), here defaults to true
> -    const auto enabledByDefaultValue = pluginInfo.rawData()["KPlugin"].toObject()["EnabledByDefault"];
> +    auto kPlugin = pluginInfo.rawData()["KPlugin"].toObject();
> +    const QJsonValue enabledByDefaultValue = kPlugin["EnabledByDefault"];

this should work too:

`const QJsonValue enabledByDefaultValue = pluginInfo.rawData()["KPlugin"].toObject()["EnabledByDefault"];`

REPOSITORY
  R32 KDevelop

BRANCH
  test_pluginenabling

REVISION DETAIL
  https://phabricator.kde.org/D12743

To: arrowdodger, #kdevelop, mwolff
Cc: kossebau, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180529/a577b74f/attachment-0001.html>